Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apitypes.yaml: fix typo in PushRequest object definition #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

apitypes.yaml: fix typo in PushRequest object definition #1

wants to merge 1 commit into from

Conversation

Ivansete-status
Copy link
Contributor

At some point we might need to do the following:

  1. Remove all the definitions from the nwaku repo.
  2. Add a reference to this repo, in the nwaku repo so that it is easy to find the actual API defs

@Ivansete-status Ivansete-status self-assigned this Nov 1, 2023
gabrielmer
gabrielmer approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chaitanyaprem
Copy link

At some point we might need to do the following:

1. Remove all the definitions from the `nwaku` repo.

2. Add a reference to this repo, in the `nwaku` repo so that it is easy to find the actual API defs

Yep, It would be even better if this spec can be used to generate the codec and structures so that there won't be naming mismatch.

chaitanyaprem
chaitanyaprem approved these changes Mar 27, 2024
View reviewed changes
Copy link

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmer gabrielmer gabrielmer approved these changes

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@NagyZoltanPeter NagyZoltanPeter Awaiting requested review from NagyZoltanPeter

@alrevuelta alrevuelta Awaiting requested review from alrevuelta

Assignees

@Ivansete-status Ivansete-status

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ivansete-status @chaitanyaprem @gabrielmer